Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add eigenda-client testnet-integration test to integration-tests.yml workflow #820

Merged
merged 2 commits into from
Oct 23, 2024
Merged

ci: add eigenda-client testnet-integration test to integration-tests.yml workflow #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028d6ca
ci: add eigenda-client testnet-integration test to integration-tests.…
samlaf Oct 19, 2024
eca995e
tests(eigenda_client_e2e): set WaitForFinalization=false to speed up …
samlaf Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- uses: actions/setup-go@v3
with:
go-version: '1.21' # The Go version to download (if necessary) and use.
go-version: "1.21" # The Go version to download (if necessary) and use.
- run: go version

- name: Checkout EigenDA
Expand Down Expand Up @@ -79,6 +79,9 @@ jobs:
- name: Node Plugin
run: go test -v ./node/plugin/tests

- name: eigenda-client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does it take to run? If too slow, we may only run it on master branch i.e. when PR is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samlaf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm depends on batcher basically. batching interval is 10 mins on holesky testnet right now?
I think we should remove waiting for finalization.. that's just dumb to test I feel, and adds a 12 minute interval. And its testing the disperser itself more so than the client.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set waitForFinalization=false: eca995e
Ran locally and it took <2mins. Let's see here. Think it depends on when in batching interval we send the request, but should hopefully be < 10 mins otherwise we'll need to increase default 10min golang test limit just for this test.

run: go test -v ./api/clients --testnet-integration

- name: Graph Indexer
run: make build && go test -v ./core/thegraph

Expand Down
5 changes: 4 additions & 1 deletion api/clients/eigenda_client_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ func TestClientUsingTestnet(t *testing.T) {
StatusQueryRetryInterval: 5 * time.Second,
CustomQuorumIDs: []uint{},
SignerPrivateKeyHex: "2d23e142a9e86a9175b9dfa213f20ea01f6c1731e09fa6edf895f70fe279cbb1",
WaitForFinalization: true,
// Waiting for finality adds 12 minutes to the test, and is not necessary
// because we already test for this correct behavior in the unit tests using a mock disperser
// which is much faster.
WaitForFinalization: false,
})
data := "hello world!"
assert.NoError(t, err)
Expand Down
Loading