feat: eigenda client returns 503 errors (for failover purpose) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
reviewed
Oct 23, 2024
5 tasks
bxue-l2
reviewed
Oct 25, 2024
bxue-l2
reviewed
Oct 28, 2024
bxue-l2
reviewed
Oct 28, 2024
samlaf
force-pushed
the
samlaf/feat--eigenda-client-503-errors
branch
from
1588266 to
d62c2ce
Compare
6 tasks
docs: better documentation for BlobStatus in disperser.proto and disperser.go feat: eigenda-client returns 503 errors for batcher failover Update disperser/disperser.go Co-authored-by: Ethen <ethen@eigenlabs.org> Update api/clients/eigenda_client.go Co-authored-by: Ethen <ethen@eigenlabs.org> fix(lint): ErrorAPIGeneric.Error() had an infinite recursive call proto: make protoc refactor: use http status codes instead of our own enum in api errors.go docs: remove deprecated notice on eigendaClient.GetCodec() docs: make more precise DISPERSING blob status comment In both disperser.proto and disperser.go feat(503): return 503 for insufficient signatures (was returning 500 before) docs: make more precise comments for why we return 503 on blobstatus_failed docs: better comment explaining timeout while in confirmed blob status chore: update comments and asserts to reflect that disperseBlob only ever returns PROCESSING status style: clearer docstring for blobStatus_DISPERSING in disperser.proto refactor(eigenda-client): return grpc errors + one special ErrorFailover error (#843)
samlaf
force-pushed
the
samlaf/feat--eigenda-client-503-errors
branch
from
8eeb3e0 to
b5efda8
Compare
bxue-l2
approved these changes
Oct 29, 2024
bxue-l2
reviewed
Oct 29, 2024
bxue-l2
reviewed
Oct 29, 2024
bxue-l2
reviewed
Oct 29, 2024
bxue-l2
reviewed
Oct 29, 2024
bxue-l2
reviewed
Oct 29, 2024
moved eigenda_client test to disperser_client test - it was in the wrong spot
…rFailover shortcircuit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related to batcher failover project. See https://linear.app/eigenlabs/issue/EBE-60/design-fallback-mechanism-for-both-op-and-arb and ethereum-optimism/specs#434 for more details.
Basically we want eigenda-proxy to return 503 to batcher to signify "eigenda is down, failover and start submitting blobs to ethereum instead".
This PR makes the eigenda-client return 503s. eigenda-proxy will then use these, retry 3 times, and if it is still returning 503s, then return a 503 to the batcher.
The 2 sources of 503 errors that we have identified are:
TODO
Checks