Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for traffic generator docker file #840

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Fixes for traffic generator docker file #840

merged 3 commits into from
Oct 28, 2024

Conversation

cody-littley
Copy link
Contributor

Why are these changes needed?

This PR does two things:

  1. deletes some necessary arguments from the traffic generator make file (used for testing locally
  2. Include the kzg resource files in the docker image for the traffic generator

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@cody-littley
Remove unused args.
70e3099 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Merge branch 'master' into traffic-generator-2-docker2
106222e 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Include kzg resource files in docker file.
16e3e5d 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley requested a review from dmanc October 28, 2024 13:24
@cody-littley cody-littley self-assigned this Oct 28, 2024
@cody-littley cody-littley merged commit 83cf627 into Layr-Labs:master Oct 28, 2024
7 checks passed
@cody-littley cody-littley deleted the traffic-generator-2-docker2 branch October 28, 2024 18:22
ian-shim pushed a commit to ian-shim/eigenda that referenced this pull request Oct 29, 2024
@cody-littley @ian-shim
Fixes for traffic generator docker file (Layr-Labs#840)
24ab1f5 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cody-littley @dmanc