Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the grpc native instrumentation #891

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Integrate the grpc native instrumentation #891

merged 6 commits into from
Nov 13, 2024

Conversation

jianoaix
Copy link
Contributor

Why are these changes needed?

Gain visibility at gRPC level.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

dmanc
dmanc approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will the metrics look like?

@jianoaix
Copy link
Contributor Author

What will the metrics look like?

Like this: https://grafana.com/docs/grafana-cloud/monitor-applications/asserts/enable-prom-metrics-collection/application-frameworks/grpc/

@jianoaix jianoaix merged commit 3faf5ee into Layr-Labs:master Nov 13, 2024
6 checks passed
@dmanc dmanc mentioned this pull request Nov 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 approved these changes

@dmanc dmanc dmanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @dmanc @bxue-l2