Disperser Client v2 #900
Merged
Disperser Client v2 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
disperser-client-v2
branch
2 times, most recently
from
ba47d2f to
43b2f26
Compare
cody-littley
approved these changes
Nov 15, 2024
api/clients/disperser_client_v2.go
Outdated
Comment on lines
191
to
208
| func (c *disperserClientV2) GetBlobStatus(ctx context.Context, blobKey corev2.BlobKey) (*disperser_rpc.BlobStatusReply, error) { | ||
| err := c.initOnceGrpcConnection() | ||
| if err != nil { | ||
| return nil, api.NewErrorInternal(err.Error()) | ||
| } | ||
|
|
||
| request := &disperser_rpc.BlobStatusRequest{ | ||
| BlobKey: blobKey[:], | ||
| } | ||
| return c.client.GetBlobStatus(ctx, request) | ||
| } | ||
|
|
||
| func (c *disperserClientV2) GetBlobCommitment(ctx context.Context, data []byte) (*disperser_rpc.BlobCommitmentReply, error) { |
There was a problem hiding this comment.
Since this will be more on the public facing side of things, wondering if it's worth it to write godocs.
ian-shim
force-pushed
the
disperser-client-v2
branch
from
43b2f26 to
766b4eb
Compare
ian-shim
force-pushed
the
disperser-client-v2
branch
from
766b4eb to
b5ff373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks