Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track bucket instead of sizes #913

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Nov 20, 2024

Why are these changes needed?

Make the queue stats map track stats at bucket (not blob size) level.

Otherwise, if it tracks at blob size level, in worst case, there may be 32M entries, which will every inefficient to track (i.e. scan 32M entries each time it tries to update metric).

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from dmanc November 20, 2024 00:17
@jianoaix jianoaix merged commit d6b99b5 into Layr-Labs:master Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants