feat: UX improvement #258
feat: UX improvement #258
Conversation
| .process_new_signature(task_index, task_response_digest, signature, operator_id) | ||
| .await?; | ||
| info!("processed signature for index {:?}", task_index); | ||
| let quorum_reached = { |
There was a problem hiding this comment.
this assumed that 2 signatures are needed to process .
there's a better way in dev branch here
https://github.com/Layr-Labs/incredible-squaring-avs-rs/blob/b953a8127b604d91175d71e7c2b47ad4023f7e77/crates/aggregator/src/lib.rs#L320-L395
it handles all cases using total stake and quorum threshold percentage. Its hardcoded rn there with 4800 (40% of 12000(total stake))
There was a problem hiding this comment.
Yes. However, I was thinking of just waiting for a signature aggregate to be returned by the BLS aggregation service.
| #[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone)] | ||
| pub struct OperatorRegistrationConfig { | ||
| pub register_operator: bool, | ||
| pub operator_to_avs_registration_sig_salt: String, |
There was a problem hiding this comment.
i think we can name this AvsOperatorRegistrationConfig and add another struct for EigenlayerOperatorRegistrationConfig so people are not confused.
we can make the params optional that are only available in pre slashing or post slashing. like we did in writer structs.
Ex : allocation_delay, salt etc
can make a PR if you agree with this
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone)] | ||
| pub struct ContractsConfig { |
There was a problem hiding this comment.
naming ? AvsContractsConfig?
maybe one way can be |
Fixes #
What Changed?
This PR introduces two new crates to the SDK:
eigen-aggregatorandeigen-operator, with a higher-level interface than the other crates.Reviewer Checklist
changelog-Xlabels (if applies)