Simplifiing the settings and keybinds systems #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the changes to the settings system where tested and they worked. the config file will have to be deleted in order for this to work
|
There are a couple small conflicts caused by #313 |
|
I think its ready to merge now. The settings are now split up based on they value type (StringSetting, BoolSetting...) and values have to be retrieved from the SettingStore via their respective methods (settings.get_string(), ...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of the settings system used some advanced rust features which made the code hard to read, such as PhantomData mixed with lots of generics and trait-objects. It also had a RefCell inside of a Hashmap which might break the internal structure of the HashMap.
Ive changed the implementation to be more idiomatic rust code. Ive also split the settings from the keybinds and the settings system in general from the console code.
Still WIP becasue i still want to make some changes.