-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma test runner #16734
Karma test runner #16734
Conversation
Have you had a chance to check it out? It's easy (provided you already have Chrome and node.js installed):
Meanwhile... I'm gradually adding more Jasmine specs and using Karma runner. Teaser:
That's right, ~0.1 secs to run all the tests. Instant feedback! |
@LeaVerou I'm close to having almost full test coverage for Awesomplete in Jasmine soon. After it's done I plan to review tests and do some cleanup before doing PR for review on how easy Jasmine tests are. Tests are already quite useful. Some bugs were uncovered and I have some ideas about possible API tweaks. Running the whole test suite with Karma sill takes less than 1 second, so it would help a lot in quick and safe bug fixing or refactoring. |
I have no time to review this properly, but since it's separate and you seem willing to work on it, I’m merging it anyway. Thanks so much! |
Thanks Lea! Yes, I will definitely continue my work on it. One way to make it easier for you as well as others is to setup a Travis CI, so that tests will be executed on each pit push and results will be visible on github very quickly (doesn't mean no PR review necessary, but at least changes with test failures are most likely not ready for merge). Will do a separate PR for Travis CI. |
Replaces plain Jasmine spec runner with Karma test runner.
Karma test runner is a much more convenient way to run tests. It allows to run tests in multiple browsers locally or in the cloud, shows failures in console, provides debugger, can be used with Continuous Integration server as Travis CI, and so on and so forth.