Add ignore diacritics capabilities #17236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, Thank you for working on this. Later down the line we should have plugins, and this could be a plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the possibility to ignore characters with diacritics.
When the user inputs a string, it should match with the items in the list whether or not the input or the items have accented characters.
Fixes #17187
Fixes #17234
Type of changes
This PR introduces a new option Awesomplete.ignoreDiacritics (boolean, default true).
When set to true, it allows matching accented characters against non-accented characters.
When set to false, it requires characters to be the same to match.
This is an implementation of David Calhoun's blog post.