Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Framework #1

Closed
zdfs opened this issue Dec 4, 2015 · 13 comments
Closed

Testing Framework #1

zdfs opened this issue Dec 4, 2015 · 13 comments

Comments

@zdfs
Copy link
Collaborator

zdfs commented Dec 4, 2015

So I'll help write tests. Anyone have an opinion on what they'd like to use? I thought the simplest thing might be Mocha/BDD/JSDOM.

Thoughts. Votes.

@dperrymorrow
Copy link
Collaborator

I would be willing to write some tests as well.
If it were up to me I would choose Karma with Jasmine. Purely from the standpoint of thats what I have the most experience with.

Karma will let you test in many different browsers easily which I'm expecting to be important on a project like this.

http://karma-runner.github.io/0.13/index.html

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 5, 2015

I don't mind Karma, I just hate configuring it. You want to pick up that part?

@dperrymorrow
Copy link
Collaborator

sure thing, karma works great with mocha too, wanna use that instead of Jasmine?
Just have used Jasmine more, but open to using Mocha. Heard good things.

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 5, 2015

Yeah. I like Mocha more than Jasmine. But either way works. I've used them all at some point. The syntax will basically be the same.

@dperrymorrow dperrymorrow mentioned this issue Dec 5, 2015
@dperrymorrow
Copy link
Collaborator

there ya go...

@lipis
Copy link
Contributor

lipis commented Dec 5, 2015

Would be nice to setup TravisCI as well..

@LeaVerou
Copy link
Owner

LeaVerou commented Dec 5, 2015

You guys rock, thanks!
And yes, I will set up TravisCl once we have some tests :)

@dperrymorrow
Copy link
Collaborator

👍 for sure, would be nice to see that tests are passing on pull requests.

@LeaVerou
Copy link
Owner

LeaVerou commented Dec 7, 2015

Hmm, anyone has any idea why Travis doesn't seem to be working? I activated this repo on travis-ci.org, I added a .travis.yml file, nothing… What did I forget?

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 7, 2015

@LeaVerou I'm wondering if it's because there's nothing in the master branch. Could be that we need to tell Travis that we're not using master somehow?

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 7, 2015

Try something like?

# whitelist
branches:
  only:
    - gh-pages

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 7, 2015

Ah. Here we go. Seems like this is the official answer. http://stackoverflow.com/questions/12878568/travis-ci-triggers-build-only-for-master-branch-in-github-repo

@zdfs
Copy link
Collaborator Author

zdfs commented Dec 7, 2015

Ok. We have builds and a testing framework. Closing this out. We should probably make individual issues for needed tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants