-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Icons in toolbar - macOS/Chrome #629
Comments
Thanks! I'll include this in the patch later tonight. |
Awesome, thank you! |
Issue Leaflet#2012 covers mobile devices Leaflet/Leaflet.draw#629 detected an issue with svg in .leaflet-bar for retina or 'zoomed in' on chrome that would ignore scaling when using negative background positions.
@Twista - identified the issue as a chrome bug. Patch goes out tonight to fix this for Leaflet.Draw, PR Leaflet/Leaflet#5085 on Leaflet for fixing this within Leaflet. An issue has been reported to Chrome linking to this ticket as well as how to reproduce. |
@Twista Please close once you have confirmed the issue is resolved, 0.4.3 has been released. |
Just tried and works perfectly. Awesome - Thank you for very quick fix! |
Hello, first - thanks for awesome work!
There is little bug i found.
How to reproduce
be0ca82
)The easiest way how to reproduce is clone current master and open example from docs
Then use zoom tool in browser - first icon in every bar has broken icons
What behaviour I'm expecting and which behaviour I'm seeing
Expecting behaviour is that icons are not broken.
Notes
Tried on multiple computers with macOS - The problem seems to be only in Chrome (FF and Safari are ok).
Find out the problem is in CSS (
leaflet.draw.css:25
) and only if browser usesimages/spritesheet.svg
. When i changed styles to useimages/spritesheet.png
- problem disappearedI would love to send pull-request, but i'm missing experience working with SVG
Thanks!
edit: formating
The text was updated successfully, but these errors were encountered: