Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

Ability to use it on rtl language websites #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kent1D
Copy link

@kent1D kent1D commented Jun 10, 2016

Add the ability to set the language direction (ltr or rtl for Arab language for example).

Avoid problems with rtl uses

language for example).

Avoid problems with `rtl` uses
@yohanboniface
Copy link
Member

Hey Kentin ;)
Which Leaflet version are you using? If 1.0, can you have a try with https://github.com/umap-project/Leaflet.Label ?

@kent1D
Copy link
Author

kent1D commented Jun 10, 2016

0.7 at the moment ;)
Le ven. 10 juin 2016 à 20:03, Yohan Boniface notifications@github.com a
écrit :

Hey Kentin ;)
Which Leaflet version are you using? If 1.0, can you have a try with
https://github.com/umap-project/Leaflet.Label ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#155 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAK6OBuIJ-1XIxnaWhoAkEI0zr1QjA1Qks5qKabtgaJpZM4IzK0d
.

@kent1D
Copy link
Author

kent1D commented Jun 10, 2016

I will have a try next week on 1.0 and your plugin, but I doubt to have the
courage to use a non stable version of leaflet at the moment.

Even if I know it may be stable soon ;)
Le ven. 10 juin 2016 à 20:04, Quentin Drouet kent1@arscenic.info a écrit :

0.7 at the moment ;)
Le ven. 10 juin 2016 à 20:03, Yohan Boniface notifications@github.com a
écrit :

Hey Kentin ;)
Which Leaflet version are you using? If 1.0, can you have a try with
https://github.com/umap-project/Leaflet.Label ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#155 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAK6OBuIJ-1XIxnaWhoAkEI0zr1QjA1Qks5qKabtgaJpZM4IzK0d
.

@kent1D
Copy link
Author

kent1D commented Jun 10, 2016

As I see on your version you may have the same "bug" I think, isn't it? I
will have a look next week and maybe propose a similar patch.
Le ven. 10 juin 2016 à 20:06, Quentin Drouet kent1@arscenic.info a écrit :

I will have a try next week on 1.0 and your plugin, but I doubt to have
the courage to use a non stable version of leaflet at the moment.

Even if I know it may be stable soon ;)
Le ven. 10 juin 2016 à 20:04, Quentin Drouet kent1@arscenic.info a
écrit :

0.7 at the moment ;)
Le ven. 10 juin 2016 à 20:03, Yohan Boniface notifications@github.com
a écrit :

Hey Kentin ;)
Which Leaflet version are you using? If 1.0, can you have a try with
https://github.com/umap-project/Leaflet.Label ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#155 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAK6OBuIJ-1XIxnaWhoAkEI0zr1QjA1Qks5qKabtgaJpZM4IzK0d
.

@yohanboniface
Copy link
Member

Isn't the option to switch left and right when in rtl mode?

@yohanboniface
Copy link
Member

I doubt to have the courage to use a non stable version of leaflet at the moment

I don't know the work needed for you to upgrade, but basically Leaflet itself is considered more stable on 1.0.0-rc than the 0.7 version. But we can't say the same for all the plugins, so your upgrade path will mainly depend on which plugins you are using.

@kent1D
Copy link
Author

kent1D commented Jun 10, 2016

It doesn't only depends on me, but also on brunob for you know what CMS plugin (which isn't at that time in the leaflet list) ;)

The left and right option is, to my mind, more a way to qualify manually where to put the tooltip, but the way to calculate it is false when you use rtl direction (at least for a western european computer, but I think for everyone).

The offsets become false.

The way it should be is inversed in rtl compared to the ltr.

(Sorry for my poor english)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants