L.DomUtil.getPosition should return a fallback value (for VML in IE8) #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
added a commit
that referenced
this pull request
Nov 9, 2015
L.DomUtil.getPosition should return a fallback value (for VML in IE8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some weird reason I don't totally understand, the VML container in IE8 is not initialized with a call to
DomUtil.setPosition. The consequence is that calls tomap.setView()ormap.fitBounds()trigger an exception whenever there is a VML renderer in the map.A default/fallback value for
L.DomUtil.getPositionfixes the issue.