Ignore dash arrays with non-numeric entries in canvas #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test seems to fail since they timeout at different places i Travis 😞 |
ghybs
reviewed
Oct 27, 2018
Co-Authored-By: perliedman <per@liedman.net>
|
Hi @cherniavskii, Please would you have some clue how to fix this error in Travis?
(Firefox test section) |
|
@ghybs I have no idea what went wrong, but build restart helped :D |
|
Btw, Github Suggested Changes feature looks neat! |
mourner
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less exactly the fix suggested by @ghybs in #6367 (comment)
I thought about adding a test, but could not come up with a failure scenario that could be tested except visually, since the problem only occurs inside the canvas rendering internals.