Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JS to JavaScript #7578

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Change JS to JavaScript #7578

merged 2 commits into from
Oct 29, 2021

Conversation

vanillajonathan
Copy link
Contributor

No description provided.

ivanetra
ivanetra approved these changes Oct 1, 2021
View reviewed changes
Copy link

@ivanetra ivanetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be merged!

@Falke-Design Falke-Design added the docs Improvements or additions to documentation label Oct 28, 2021
jonkoops
jonkoops approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the value of this change, but there is no harm in being more explicit in places where 'regular' users might interact with this.

@jonkoops jonkoops merged commit 3746690 into Leaflet:master Oct 29, 2021
@vanillajonathan vanillajonathan deleted the patch-1 branch October 29, 2021 19:40
@Falke-Design Falke-Design mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanBnm NathanBnm NathanBnm approved these changes

@ivanetra ivanetra ivanetra approved these changes

@Falke-Design Falke-Design Falke-Design approved these changes

@jonkoops jonkoops jonkoops approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vanillajonathan @jonkoops @Falke-Design @ivanetra @NathanBnm