Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest version of Rollup #7677

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Upgrade to latest version of Rollup #7677

merged 3 commits into from
Oct 29, 2021

Conversation

jonkoops
Copy link
Collaborator

Also cleans up the build configuration itself a little so it's a bit more DRY and conforms to the linting standards of the project.

@mourner
Copy link
Member

mourner commented Oct 19, 2021

The reason we held on to the older Rollup is that it supported the legacy option, allowing ES3 as the target — we still formally support very old IE versions with Leaflet, and dropping this (although something we should do) would need a major version bump, so needs to be done carefully and with a lot of consideration.

@jonkoops
Copy link
Collaborator Author

@mourner I checked the output between these versions and they seem pretty compatible to me, I will take a look and see if this remains functional in older browsers.

@jonkoops jonkoops added dependencies Pull requests that update a dependency file needs investigation labels Oct 28, 2021
@jonkoops jonkoops self-assigned this Oct 28, 2021
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After studying rollup/rollup#2141 very carefully, I discovered that we can keep compatibility with IE8 if we use both freeze: false and esModule: false. 🎉 Haven't actually tested on IE8 (lol), but pretty sure we can proceed with the upgrade.

@mourner mourner merged commit da32372 into Leaflet:master Oct 29, 2021
@mourner
Copy link
Member

mourner commented Oct 29, 2021

cc @IvanSanchez

@jonkoops jonkoops deleted the feature/upgrade-rollup branch October 29, 2021 19:11
@jonkoops
Copy link
Collaborator Author

Awesome @mourner! Should we also update the supported browsers on the site? It would seem that Internet Explorer 7 isn't supported anymore if I read this correctly.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants