Remove gap between leaflet-popup-tip-container and leaflet-popup-content-wrapper
#7920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malvoz
commented
Jan 18, 2022
Comment on lines
-544
to
-546
| .leaflet-oldie .leaflet-popup-tip-container { | ||
| margin-top: -1px; | ||
| } |
There was a problem hiding this comment.
These lines are now redundant, since the same styling is applied to leaflet-popup-tip-container in general.
|
Should we now move the popup anchor 1px down? |
mourner
approved these changes
Jan 19, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaflet-popup-tip-containerandleaflet-popup-content-wrapperOriginally posted by @mourner in #7908 (comment)
The gap can be seen in the screenshot below. I was able to reproduce the gap consistently in Chrome 97.0.4692.71. In Firefox 95.0.2 it wasn't always visible, and sometimes only visible during zoom.
Preview