Added support for dashed strokes. #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that there is already an open issue for this: #165 |
mourner
added a commit
that referenced
this pull request
Jul 24, 2012
Added support for dashed strokes.
|
Thanks! |
|
I've added normalization of dashArray to VML code so that it accepts comma-separated values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we style the stroke of a vector shape as dashed. Initially I thought to do this with css. SVG supported this, VML did not :(
This pull adds the stroke property dasharray/dashstyle to paths. VML needs a string or lengths separated by spaces and SVG can take both space separated or comma separated.
http://msdn.microsoft.com/en-us/library/bb264085(v=vs.85).aspx
https://developer.mozilla.org/en/SVG/Attribute/stroke-dasharray
Tested in IE7, IE8-9 (via IE9), FF, Chrome & Safari.
I haven't updated the docs yet. I notice you're working on them at the moment. Would you like me to add this property to the gh-pages-master branch (assuming this pull is accepted)?