Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of global L and safeguard against it #8536

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Oct 6, 2022

Fixes #8533, closes #8535. Apologies @Falke-Design — made a fix in parallel to you. In addition to the fix, adjusts the linting config so that we catch those cases in the future.

@mourner mourner requested a review from Falke-Design October 6, 2022 16:54
@mourner mourner mentioned this pull request Oct 6, 2022
Copy link
Member

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem 👍

@mourner mourner merged commit 8ae526b into main Oct 6, 2022
@mourner mourner deleted the safeguard-global-use branch October 6, 2022 16:57
@mourner
Copy link
Member Author

mourner commented Oct 6, 2022

Cherry-picked to v1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on DivOverlay.js when using Leaflet as esm module
2 participants