Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump actions/cache dependency version to v4 #15

Merged
merged 1 commit into from
Feb 20, 2024
Merged

chore(deps): bump actions/cache dependency version to v4 #15

merged 1 commit into from
Feb 20, 2024

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Feb 19, 2024

Context

With Node 16 reaching End-of-life, Github actions deprecated it as runner of the GitHub actions on Sept 2023 (see: GitHub Actions: Transitioning from Node 16 to Node 20
).

image

Proposed fix

To fix the deprecation warning, this PR updates the actions/checkout action to the new major version, v4, using the new runtime recommended version: Node 20.

@LNSD
Copy link
Contributor Author

LNSD commented Feb 19, 2024

Additionally, the actions/cache action in the latest released version supports the save-always flag, which would resolve #14

image
Source: https://github.com/actions/cache/tree/main#v4

Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd welcome a PR to add the save-always flag as well.

@alice-i-cecile alice-i-cecile merged commit c4eff7b into Leafwing-Studios:main Feb 20, 2024
@LNSD LNSD deleted the chore-deps-update-cache-version branch February 20, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants