Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-sweep support #28

Merged
merged 4 commits into from
Aug 24, 2024
Merged

cargo-sweep support #28

merged 4 commits into from
Aug 24, 2024

Conversation

BD103
Copy link
Collaborator

@BD103 BD103 commented Aug 21, 2024

This adds initial integration with BD103/cargo-sweep, closing #24 and BD103/cargo-sweep#4. It is opt-in and intended to be released in v2.3.0 as a non-breaking change.

My plan after this is merged is as follows:

  1. Install cargo-sweep to ~/.cargo/bin BD103/cargo-sweep#6
  2. Cache cargo-sweep installation BD103/cargo-sweep#1
  3. Make sweep-cache true by default as part of v3.0.0 release
  4. Improve documentation of cargo-sweep in general

@BD103 BD103 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Aug 21, 2024
@BD103 BD103 requested a review from TimJentzsch August 21, 2024 00:30
@TimJentzsch
Copy link
Collaborator

Do you have an example run of this version available?

@BD103 BD103 added the enhancement New feature or request label Aug 21, 2024
@BD103
Copy link
Collaborator Author

BD103 commented Aug 22, 2024

Do you have an example run of this version available?

Yup! In this run I generated a cache that depends on Bevy 0.12, and in this run downloaded the existing cache, updated to Bevy 0.14, and purged 1.3 GiB from target before uploading it again.

This is the original workflow file, which is pretty bare-bones.

Copy link
Collaborator

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, post actions seem to run in the correct order and second run cleaned up 1.3 GB which would pile up otherwise.

Let's try it out!
I won't be able to trigger the release until Saturday or Sunday though.

@TimJentzsch
Copy link
Collaborator

Oh actually, @BD103 can you add the new input parameters to the Readme as well before we merge this?

@BD103
Copy link
Collaborator Author

BD103 commented Aug 23, 2024

Oh actually, @BD103 can you add the new input parameters to the Readme as well before we merge this?

Good catch! I'll get this done by Saturday.

@BD103
Copy link
Collaborator Author

BD103 commented Aug 24, 2024

Sorry for taking so long, but the README.md is now updated!

@BD103 BD103 marked this pull request as draft August 24, 2024 20:02
@BD103 BD103 marked this pull request as ready for review August 24, 2024 20:09
@BD103
Copy link
Collaborator Author

BD103 commented Aug 24, 2024

I've just released v1.3.0, which exposes cargo-sweep caching as you suggested.

With this, I've now "hidden" prebuilt binaries so that they can no longer be enabled. Caching is preferred because it just requires trust in https://crates.io, as compared to a random artifact uploaded to Github.

Copy link
Collaborator

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out :)

@TimJentzsch TimJentzsch merged commit d8d3ade into main Aug 24, 2024
@TimJentzsch TimJentzsch deleted the cargo-sweep branch August 24, 2024 21:26
@TimJentzsch
Copy link
Collaborator

I can probably release this tomorrow.
If not, feel free to ping me on Discord :)

@BD103
Copy link
Collaborator Author

BD103 commented Aug 25, 2024

I can probably release this tomorrow. If not, feel free to ping me on Discord :)

Alice gave me collaborator privileges, so I can do so as well! (If you don't get to it first 😄)

@BD103 BD103 linked an issue Aug 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused dependencies before saving cache
3 participants