Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use required components for InputMap (requires ActionState) #676

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

use required components for InputMap (requires ActionState) #676

wants to merge 7 commits into from

Conversation

atornity
Copy link

  • InputMap now requires ActionState.
  • deprecated InputManagerBundle in favor of required components.
  • I did not touch the press_duration example because I couldn't get it to work (on this or main)

before:

commands.spawn((Player, InputManagerBundle::with_map(input_map)));

after:

commands.spawn((Player, input_map));

@atornity
InputMap requires ActionState
f69630f
@atornity
deprecate InputManagerBundle
1d32d13
@atornity
examples
0d5bce4 
tested about half of them, they seem to still work as expected :)
@atornity
tests
bd2e666 
still passes :)
@alice-i-cecile
Copy link
Contributor

Good stuff, I like that. Add a note to RELEASES.md for users please?

@atornity
Copy link
Author

Good stuff, I like that. Add a note to RELEASES.md for users please?

I hope I added it to the right section

@atornity
Copy link
Author

It complains about using a deprecated InputManagerBundle in lib.rs (which is where it's defined) for some reason, and the workflows fail because of that. Should I just remove the bundle altogether?

alice-i-cecile
alice-i-cecile reviewed Jan 12, 2025
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) January 13, 2025 00:47
@alice-i-cecile alice-i-cecile added usability Reduce user friction breaking-change A breaking change that requires a new major version labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
breaking-change A breaking change that requires a new major version usability Reduce user friction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atornity @alice-i-cecile