Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Bevy 0.15 #68

Closed
wants to merge 4 commits into from
Closed

Conversation

CosterM
Copy link
Contributor

@CosterM CosterM commented Dec 3, 2024

Support bevy 0.15
I have not changed any Bundles over to using required components, as it is not strictly necessary for 0.15 support

This depends on Leafwing-Studios/leafwing-input-manager#644

Notes:

  • Doctests and examples were broken on main, so I fixed those so I could verify my changes. Let me know if you'd like a separate PR for those changes.
  • examples/cooldown.rs is using crlf line endings for some reason? presumably not intended? I've left the line endings as is for this PR, so it doesn't look like i've changed the whole file when reviewing etc.
  • The examples are affected by this issue Runtime error when using bevy_winit feature without explicitly adding bevy_window bevyengine/bevy#16568, so I have added an extra entry to the bevy features in dev-dependencies with a comment

@alice-i-cecile
Copy link
Contributor

This looks great; thanks for all the fixes. I'll take a look at the linked LWIM PR too :)

examples/cooldown.rs is using crlf line endings for some reason? presumably not intended? I've left the line endings as is for this PR, so it doesn't look like i've changed the whole file when reviewing etc.

Yeah, this is unintended.

@alice-i-cecile alice-i-cecile marked this pull request as ready for review December 15, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants