Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Print the time when the program started running #162

Merged
merged 4 commits into from
Feb 22, 2023
Merged

feat: Print the time when the program started running #162

merged 4 commits into from
Feb 22, 2023

Conversation

ItsSpirax
Copy link
Contributor

Fixes #159

Summary of Changes

Prints the time when the program started in the welcome message

image

Additional context

I don't know which format (UTC / Local time, 24-hour/ 12-hour) will be more helpful, you guys can make the final decision.

Discord username (if different from GitHub): Spirax#3775

Testing instructions

Verify that the welcome message shows the current time on start.

How to download the PR for testing

Using GitHub CLI

  1. Clone this PR
  2. Run gh pr checkout 124 (Requires GitHub CLI)
  3. Follow the Advanced Installation Guides from the Wiki

Using regular GIT

  1. Fetch the PR git fetch origin pull/<PR_NUMBER>/head:<LOCAL_BRANCH_NAME> (e.g. git fetch origin pull/110/head:notif)
  2. Checkout the branch git checkout <LOCAL_BRANCH_NAME> (e.g. git checkout notif)
  3. Follow the Advanced Installation Guides from the Wiki

src/main.py Outdated Show resolved Hide resolved
@ItsSpirax
Copy link
Contributor Author

Does this look good?

image

@Skribb11es
Copy link
Contributor

LGTM

@alepouna alepouna added the enhancement New feature or request label Feb 21, 2023
@LeagueOfPoro LeagueOfPoro merged commit 0017c0d into LeagueOfPoro:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion]: include what time the program started working
4 participants