Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Progress #8 -- Adding compiled binaries #10

Open
wants to merge 5 commits into
base: indev
Choose a base branch
from
Open

Progress #8 -- Adding compiled binaries #10

wants to merge 5 commits into from

Conversation

danil179
Copy link

@danil179 danil179 commented Oct 20, 2019

Adding configuration
Adding x64 binaries

Progress #8

Adding configuration
@danil179
Copy link
Author

These binaries are actually not working. You must compile with CMake and not with VS.

@danil179
Copy link
Author

Uploaded correct libs. Now only linux and mac-osx libs need to be uploaded.

@MatthewFrench
Copy link

MatthewFrench commented Mar 22, 2020

@danil179 What's the correct process for uploading linux and mac libs? Is that something someone else has to do before this pull request is ready?

@danil179
Copy link
Author

@MatthewFrench We need linux+mac binaries (it is not that urgent for this PR and we can add it later probably). The x86 libs have all the libs, but x64 lacks linux+mac ones.

@MatthewFrench
Copy link

@danil179 We should push to get this merge request merged and I suppose I could help with a new pull request with linux/mac libs since I have a Mac.

@danil179
Copy link
Author

@MatthewFrench You can just push them into the branch (this branch is local, so no need to open a new one).

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ danil179
❌ mfrench-indeed
You have signed the CLA already but the status is still pending? Let us recheck it.

@LeagueRaINi
Copy link

github is not a place to store precompiled binaries aside from the release tab
so i sure hope this pr gets denied

instead of uploading precompiled dlls just make a bat script that compiles these dlls from source

hope ur happy now @MatthewFrench

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants