This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Progress #1407 -- HandleSpawn and Champion refactor
#1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzardy
approved these changes
May 1, 2022
| @@ -544,7 +544,8 @@ public interface IPacketNotifier | |||
| /// </summary> | |||
| /// <param name="clientInfo">Information about the client which had their hero created.</param> | |||
| /// <param name="userId">User to send the packet to. Set to -1 to broadcast.</param> | |||
| void NotifyS2C_CreateHero(ClientInfo clientInfo, int userId = -1); | |||
| /// <param name="doVision">Whether or not to package the packets into a vision packet.</param> | |||
There was a problem hiding this comment.
Although this option can be streamlined for all other packets, I'll accept for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the
HandleSpawnclass and unified the spawning of champions with the spawning of other objects, moving most of the code into the appropriate class.Other changes:
NotifyS2C_CreateHerofunction now accepts an optional parameter that allows the packet to be wrapped in a vision packet when sent, similar to theNotifySpawnfunction.NotifySpawnis now set to false by default.userIdwith0are reduced to the form<=.