Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleverTap Push fixes #569

Merged
merged 2 commits into from
Jul 19, 2023
Merged

CleverTap Push fixes #569

merged 2 commits into from
Jul 19, 2023

Conversation

nzagorchev
Copy link
Contributor

What Where/Who
JIRA Issue SDK-3124
People Involved @nzagorchev

Background

  • Fix isEqualToHandledNotification for CleverTap notifications.
    If the app is launched from a CleverTap push notification, the consequent CleverTap notification opens will not work since isEqualToHandledNotification always returns true for CleverTap notifications - for notifications without notification Id (lp_occurrence_id key).

  • Default CleverTap openDeepLinksInForeground to true when called from notificationOpened, unless openDeepLinksInForeground is explicitly set. Fixes an issue on Unity when the application is opened from a notification and the app takes a while to load. At that point, the notification open in CleverTap is executed when the app is in the foreground.

Implementation

  • Check if notifications have a notification Id set - the id should not be equal to the default one returned by the method -1.
  • openDeepLinksInForeground is nil unless set explicitly. If not set, default to the notification event being Open or Receive. Use openDeepLinksInForeground: true if Opened.

Testing steps

Is this change backwards-compatible?

@nzagorchev nzagorchev merged commit 6d18f0f into master Jul 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the ct-push branch July 19, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants