Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Zulip integration - missing whitespace character in message #536

Closed
mateuszmandera opened this issue Dec 16, 2021 · 0 comments
Closed
Labels
Bug Fixed and Staged Fixed in Master and ready to be included in the next release

Comments

@mateuszmandera
Copy link

mateuszmandera commented Dec 16, 2021

In the Zulip integration code (ref #92)

$prepareChatMessage .= "".$url['link']."";
the message content is created:

                $prepareChatMessage = "**Project: ".$projectName."** \n\r".$message;
                if($url !== false){
                    $prepareChatMessage .= "".$url['link']."";
                }

and there's no whitespace character before the $url. Leading to the message looking like:

Project: xxxx
Xxxxxxhttps://example.com

The bugged message was reported by a user to us at https://github.com/zulip/zulip/ but it looks like a bug in the integration.

@marcelfolaron marcelfolaron added the Fixed and Staged Fixed in Master and ready to be included in the next release label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed and Staged Fixed in Master and ready to be included in the next release
Projects
None yet
Development

No branches or pull requests

2 participants