Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2392 #2393

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Issue 2392 #2393

merged 3 commits into from
Mar 12, 2024

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Mar 11, 2024

Link to ticket

#2392

Description

Adds a getCurrentProjectId function in Leantime\Domain\Projects\Services\Projects and uses it instead of $_SESSION['currentProject'] in select places (the ones calling Projects::getProject()).

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

@rimi-itk rimi-itk marked this pull request as ready for review March 11, 2024 13:55
@rimi-itk rimi-itk requested a review from a team as a code owner March 11, 2024 13:55
@rimi-itk rimi-itk requested review from marcelfolaron and removed request for a team March 11, 2024 13:55
Copy link
Contributor

@marcelfolaron marcelfolaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marcelfolaron marcelfolaron merged commit f4432d6 into Leantime:master Mar 12, 2024
6 of 7 checks passed
@rimi-itk rimi-itk deleted the issue-2392 branch March 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants