1622: edit comment on todos #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcelfolaron
approved these changes
Jun 24, 2024
|
Thank you! This was a long requested features! |
jeppekroghitk
approved these changes
Jun 25, 2024
| jQuery('.mainToggler-'+formHash).hide(); | ||
|
|
||
|
|
||
| if (parseInt(id, 10) === 0) { |
There was a problem hiding this comment.
Radix is 10 by default, so the second parameter in parseInt() can be removed.
There was a problem hiding this comment.
Yeah true, I added it though, because if ever a linter is setup on this project it would probably complain about this.
app/Domain/Comments/Templates/submodules/generalComment.sub.php
Outdated
Show resolved
Hide resolved
| jQuery('#comment-'+formHash+'-' + id + ' .commentReply').prepend('<textarea rows="5" cols="75" name="text" id="editor_'+formHash+'" class="tinymceSimple"></textarea>'); | ||
| jQuery(`.commentBox-${formHash} textarea`).remove(); | ||
| jQuery(`.commentBox-${formHash}`).hide(); | ||
| jQuery(`#comment-${formHash}-${id} .commentReply`).prepend(`<textarea rows="5" cols="75" name="text" id="editor_${formHash}-${id}" class="tinymceSimple">${editComment ? jQuery(`#comment-text-to-hide-${isReply ? 'reply-' : ''}${formHash}-${commentId || id}`).html() : ''}</textarea>`); |
| jQuery('.mainToggler-'+formHash).hide(); | ||
|
|
||
|
|
||
| if (parseInt(id, 10) === 0) { |
There was a problem hiding this comment.
Suggested change
| if (parseInt(id, 10) === 0) { | |
| if (parseInt(id) === 0) { |
remove embarrassing comma that snuck into my function declaration Co-authored-by: Jeppe Julius Krogh <106669866+jeppekroghitk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/1622
Description
Screenshot of the result
Buttons:
Editing:
Additional comments or questions
If you have any further comments or questions for the reviewer, please add them here.