Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments component #2564

Merged
merged 11 commits into from
Aug 27, 2024
Merged

Comments component #2564

merged 11 commits into from
Aug 27, 2024

Conversation

marcelfolaron
Copy link
Contributor

Link to ticket

Please add a link to the GitHub issue being addressed by this change.

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface, you should include a screenshot of the result with the pull request.

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

@marcelfolaron
Copy link
Contributor Author

@sinejespersen FYI I am working on centralizing the comments function into one central component. Your edit comment functionality would be great for this PR as well. Maybe we can work on it together.

@sinejespersen
Copy link
Contributor

@sinejespersen FYI I am working on centralizing the comments function into one central component. Your edit comment functionality would be great for this PR as well. Maybe we can work on it together.

You are welcome to merge the comment pr, if that is what you mean?

@marcelfolaron marcelfolaron changed the base branch from master to 3.3-dev August 27, 2024 15:00
@marcelfolaron marcelfolaron marked this pull request as ready for review August 27, 2024 15:01
@marcelfolaron marcelfolaron requested a review from a team as a code owner August 27, 2024 15:01
@marcelfolaron marcelfolaron requested review from muhtasimhafiz and removed request for a team August 27, 2024 15:01
@marcelfolaron marcelfolaron merged commit 695fe04 into 3.3-dev Aug 27, 2024
1 check passed
@marcelfolaron marcelfolaron deleted the commentsComponent branch August 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants