2차 멘토링 코드리뷰용 PR #26
Closed
2차 멘토링 코드리뷰용 PR #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p logic Log-in and membership registration logic using JWT was implemented. Related: #1
…ging-in-directory-structure-and-implementing-subscription-logic [Feature] Setting up and logging in directory structure and implementing subscription logic
Related: #3
…settings [Feature] Implements Deploy Settings
Related:
Related:
Related:
Related:
Related:
Related:
Related:
Related:
Related:
Related:
Related:
Related:
[Feature/#4] 일기 CRUD 기능 구현
[Chore/#9] 일기 작성 기능 수정
Related:
Related:
[Feature/#8] 행동 요령 제안 기능 구현
[Feature/#16] 감정 분석 레포트 기능 구현
[Feature/#20] 감정 분석 레포트 상세 조회 기능 구현
[Feature/#18] 홈 화면 조회 기능 구현
implement OpenAI API connection in service layer. Related: #14
…uide [Feature] Implement Todo Guide
Related:
Generate personalized compliment card content and title based on user diary entries. Related: #24
…ment-card-feature [FEATURE] Implement Compliment Card Feature
Now, return Todo Guide at postTodo Related:
update Todo Guide Related:
anselmo228
approved these changes
Nov 24, 2024
| run: | | ||
| echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin | ||
|
|
||
| - name: JIB로 Docker 이미지 빌드 및 푸시 |
There was a problem hiding this comment.
EC2 스펙을 어떤걸 사용하는지 모르곘으나, t2.micro와 같은 낮은 사양에서는 'docker prune'과 같은 명령어를 통해 디스크를 확보해두는게 안정적입니다!
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/v1/diary") |
There was a problem hiding this comment.
RESTFUL 하게 API를 짜는것에 있어, url은 복수형으로 변경하는건 어떨까요?
|
|
||
| @Getter | ||
| @NoArgsConstructor | ||
| public class DiaryAnalysisRequest { |
There was a problem hiding this comment.
Param이 한개면 굳이 DTO로 묶은 이유가 있으실까요?? 딱히 문제가 되는건 아니지만 나중 유지 보수를 위해서는 Request Param 단일 변수로 받고 "일기 내용을 입력해주세요." 이부분은 Controller에서 Swagger @parameter로 넣는것도 좋아보입니다!
지금도 좋긴합니다!
Comment on lines
+9
to
+11
| HAPPY("행복", "🥰", 1), DELIGHT("기쁨", "🥳", 2), EXCITING("신남", "😝", 3), | ||
| SOSO("보통", "😐", 4), | ||
| ANNOYING("짜증", "😫", 5), SAD("슬픔", "😢", 6), ANGRY("화남", "😡", 7); |
Comment on lines
+45
to
+53
| validContentLength(request.getContent()); | ||
|
|
||
| Long userId = getUserIdFromAuthentication(); | ||
|
|
||
| User user = findUserById(userId); | ||
|
|
||
| String guide = getTodoGuide(request.getContent()); | ||
|
|
||
| planRepository.save(PlanConverter.toPlan(request.getContent(), user, guide)); |
확인했습니다 자세한 코드 리뷰 감사합니다 !! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.