Open
Conversation
Testing the database is separate from the route testing. Contact should be tested in the `getContacts` function in the integration test.
jaredatron
reviewed
Sep 15, 2017
| - All "End to End" and Integrations tests are setup such that the database tables are truncated, and seeded before each test run. | ||
| - End to End testing: Test the http routes exposed in the server | ||
| - You have `chai-http` installed | ||
| - A test for the `/` GET route to make sure that the correct page is getting rendered and all the contacts are being received from the database |
Contributor
There was a problem hiding this comment.
its possible and totally reasonable to have a test that:
- insert users into the database
- renders '/'
- asserts that the page that was rendered contains the users we put in the database
Contributor
There was a problem hiding this comment.
@SomayaB I would love to have a dialog about this. Can we chat sometime?
Contributor
There was a problem hiding this comment.
I'd love for @punitrathore to make the call on this one since its phase 3 curriculum content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the database is separate from the route testing. Contact should be tested in the
getContactsfunction in the integration test.