Conversation
Both CI links produce a 404 page. Also, the one at the top is a bare link with no explanation to the reader about why it is there.
Changed nouns to verbs.
For Learners completing all installations in order, IDM and Echo will already be installed and possibly running.
Made it identical to the one in the Echo instructions, for consistency.
Seems better in the .env file itself than in the instruction file.
This is consistent with the final step in the Echo installation instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides tests as required by issue 376.
The PR includes a change to /knexfile.js making pg.defaults.ssl false when NODE_ENV = 'test'. The instructions in DEVELOPMENT.md do not specify any configuration for a 'test' environment. Without this change it would be necessary to provide such instructions, including enabling SSL connections to the local PostgreSQL cluster.
The tests of the commands function avoid using the queries functions to examine the resulting tables, using child-process calls to psql instead, so that each test is a test only of the command function and not of the interaction between it and the queries functions.