adds functionality for updating contacts on hubspot when their phase is changed#1099
Open
je-lopez wants to merge 4 commits intoLearnersGuild:masterfrom
Open
adds functionality for updating contacts on hubspot when their phase is changed#1099je-lopez wants to merge 4 commits intoLearnersGuild:masterfrom
je-lopez wants to merge 4 commits intoLearnersGuild:masterfrom
Conversation
jaredatron
suggested changes
Sep 13, 2017
Contributor
jaredatron
left a comment
jaredatron
left a comment
There was a problem hiding this comment.
looks good. Where are the tests?
je-lopez
force-pushed
the
1070-update-hubspot
branch
from
869c3f1 to
5b8e182
Compare
Author
|
Test added, and created files for the functions that were in index |
jaredatron
reviewed
Sep 14, 2017
Contributor
jaredatron
left a comment
jaredatron
left a comment
There was a problem hiding this comment.
assuming @prattsj doesn't spot anything this looks good to me
| contactProfileByEmail: email => `/contacts/v1/contact/email/${email}/profile`, | ||
| contactProfileByVID: vid => `/contacts/v1/contact/vid/${vid}/profile`, | ||
| } | ||
| import {default as getContactByEmail} from './getContactByEmail' |
Contributor
There was a problem hiding this comment.
Do we have a linter that prefers:
import {default as getContactByEmail} from './getContactByEmail'over:
import getContactByEmail from './getContactByEmail'
heyheyjp
previously approved these changes
Sep 14, 2017
Collaborator
|
Please dismiss my previous review - was an accident. Intended for another PR reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1070
Overview
Whenever a member's phase has been changed in echo, the phase property of the HubSpot contact for that member should be updated as well in a worker
Notes
Also extracts functions from index allowing only importing/exporting