Used newspaper #13
Used newspaper #13
Conversation
Use of newspaper3k library to extract title instead of beautifulsoup4.
|
the bs4 import is still included |
|
Beautiful soup library does not have any functionality. I will merge this and delete that line on the next commit |
Nope, the one making the pull request should supply good code with no redundancy and good efficiency. This is to minimize the actions to master directly. Actions directly to master should not be done. Ever. |
Removed redudancy.
Removed urllib
|
@mandjevant sure |
Reinstated urllib2 and added try and except for internet connection.
Added sys and removed net_con. Directly exits from sys.exit() when the URL is not reachable.
|
I have made the required changes. Please confirm @mandjevant |
Looks good to me! |
|
Can this be merged? |
|
@mphirke i dont think that will be a problem. Cuz I have made all the changes on top of your code. I had copied headline.py from your fork and then added the changes. So as long as other files don disrupt we'll be fine |
4 participants
I read Slack and implemented "- Using Newspaper instead of BeautifulSoup [Provides all news scraping capabilities]"