Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Statement): Add alternative publish to queue logic without using Redis (LLC-2162) #890

Merged
merged 12 commits into from
Mar 20, 2023
Merged

feat(Statement): Add alternative publish to queue logic without using Redis (LLC-2162) #890

merged 12 commits into from
Mar 20, 2023

Conversation

PrinceWaune
Copy link
Contributor

@PrinceWaune PrinceWaune commented Mar 3, 2023 •
edited by jira bot
Loading

Closes LLC-2162.

@codecov
Copy link

codecov bot commented Mar 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 38.29% and project coverage change: -0.37 ⚠️

Comparison is base (22ea51f) 94.25% compared to head (d80c705) 93.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   94.25%   93.88%   -0.37%     
==========================================
  Files         652      655       +3     
  Lines        7100     7147      +47     
  Branches      789      795       +6     
==========================================
+ Hits         6692     6710      +18     
- Misses        286      315      +29     
  Partials      122      122
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
...tatements/repo/eventsRepo/emitNewStatements/sqs.ts 33.33% <33.33%> (ø)
...tements/repo/eventsRepo/utils/sqsEvents/factory.ts 33.33% <33.33%> (ø)
src/utils/connectToSQS.ts 45.45% <45.45%> (ø)
src/apps/statements/repo/eventsRepo/factory.ts 71.42% <50.00%> (-8.58%) ⬇️
...apps/statements/repo/eventsRepo/utils/constants.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

crazy-grizzly
crazy-grizzly reviewed Mar 13, 2023
View reviewed changes
src/utils/connectToSQS.ts
Comment on lines +6 to +7
export default once((): (() => Promise<SQSClient>) => {
return once(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrinceWaune , double once? 👀

crazy-grizzly
crazy-grizzly approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@crazy-grizzly crazy-grizzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ToranSharma ToranSharma merged commit 393bad4 into master Mar 20, 2023
@ToranSharma ToranSharma deleted the LLC-2162 branch March 20, 2023 14:55
@HT2Bot
Copy link
Member

HT2Bot commented Mar 20, 2023

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-grizzly crazy-grizzly crazy-grizzly approved these changes

@lydiamross lydiamross lydiamross approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrinceWaune @HT2Bot @crazy-grizzly @lydiamross @ToranSharma