feat(DB): Introduce DB write concern env var for createStatements (LLC-2389) #896
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 93.92% 93.91% -0.01%
==========================================
Files 655 655
Lines 7146 7152 +6
Branches 795 796 +1
==========================================
+ Hits 6712 6717 +5
Misses 314 314
- Partials 120 121 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Comment on lines
+6
to
+7
|
|
||
| const WRITE_CONCERN_DEFAULT = 3; |
There was a problem hiding this comment.
MongoDB's default is majority and here our default is 3. This would create behavioural change immediately upon deployment.
| @@ -22,7 +26,11 @@ export default (config: FacadeConfig): Signature => { | |||
| }); | |||
|
|
|||
| const collection = (await config.db()).collection(STATEMENTS_COLLECTION_NAME); | |||
| await collection.insertMany(documents); | |||
| console.time('STATEMENT INSERTION'); | |||
There was a problem hiding this comment.
Logs are for measurements in the QA process only and will be removed
PrinceWaune
approved these changes
Apr 4, 2023
lydiamross
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LLC-2389.