Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signatures and ensure callback is always called #35

Closed
wants to merge 6 commits into from
Closed

Refactor signatures and ensure callback is always called #35

wants to merge 6 commits into from

Conversation

bryanchriswhite
Copy link

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@bryanchriswhite bryanchriswhite deleted the c-api-callbacks-leak-fixing branch December 1, 2021 11:23
JustusFT pushed a commit that referenced this pull request Aug 18, 2022
@Jacalz @psanford
A few smaller code cleanups
d88437e 
This commit incorporates a couple code cleanups, with some being
more important than others. Below is a summary of what has been done:

- Replaced an unnecessary `io.TeeReader` and `countWriter` with the
  bytes written by `io.Copy` (should be marginally faster than before).
- Fixed the same `prefixPath` being recalculated on each directory
  iteration (should also result in a small performance improvement).
- Move `variable = variable + number` to `variable += number`.

Closes: #35 [via git-merge-pr]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bryanchriswhite