Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup cargo config file as all unstable features are now managed th… #29

Closed
wants to merge 1 commit into from

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Oct 25, 2023

…rough a global /config.toml file in the Docker full image

…rough a global /config.toml file in the Docker full image
@yhql
Copy link
Contributor

yhql commented Oct 25, 2023

Not sure we should move those particular flags, because the app would not build without the ledger-app-builder.
Some config flags like config-host, that may be necessary for the 'lite' docker image which uses musl can be put in a global config file because they're tied to the host and not the app.

@yogh333
Copy link
Contributor Author

yogh333 commented Oct 25, 2023

@yhql Ok so your suggestion is to keep this section:

[unstable]
build-std = ["core"]
build-std-features = ["compiler-builtins-mem"]

in the app's .cargo/config.toml (and removing it from the global $CARGO_HOME/config.toml) ?

@yogh333
Copy link
Contributor Author

yogh333 commented Oct 25, 2023

I have updated the global config file accordingly: LedgerHQ/ledger-app-builder@4e28c73

@yhql
Copy link
Contributor

yhql commented Oct 25, 2023

Yes. I think if we merge #30 we'll see that this PR fails the currently non-docker build

@yogh333
Copy link
Contributor Author

yogh333 commented Oct 26, 2023

Ok I close this PR.

@yogh333 yogh333 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants