-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src:ui / tests: Update UI and tests based on new API #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 3 3
Lines 53 53
=======================================
Hits 44 44
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
2 times, most recently
from
February 29, 2024 14:37
7220de1
to
5cfe528
Compare
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
from
March 7, 2024 11:20
822b14d
to
2870aa6
Compare
6 tasks
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
from
March 12, 2024 09:38
2870aa6
to
7c6ea0f
Compare
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
3 times, most recently
from
March 27, 2024 15:16
fac080d
to
8c2fbb5
Compare
xchapron-ledger
changed the title
src/ui/menu_nbgl.c: Use nbgl_useCaseSettingsV2()
src/ui: Update NBGL UI based on new API
Mar 27, 2024
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
2 times, most recently
from
April 2, 2024 14:05
d7480c6
to
ca59959
Compare
tdejoigny-ledger
previously approved these changes
Apr 4, 2024
Removed main menu navigation test that should belong in the SDK
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
from
April 11, 2024 15:58
4e898a0
to
2108c67
Compare
xchapron-ledger
changed the title
src/ui: Update NBGL UI based on new API
src:ui / tests: Update UI and tests based on new API
Apr 11, 2024
lpascal-ledger
previously approved these changes
Apr 12, 2024
lpascal-ledger
previously approved these changes
Apr 12, 2024
xchapron-ledger
force-pushed
the
xch/nbgl-settingsv2
branch
from
April 12, 2024 08:03
e63a9fd
to
b4caa14
Compare
lpascal-ledger
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to LedgerHQ/ledger-secure-sdk#542