Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src:ui / tests: Update UI and tests based on new API #115

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

xchapron-ledger
Copy link
Contributor

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (23f7b03) to head (b4caa14).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files           3        3           
  Lines          53       53           
=======================================
  Hits           44       44           
  Misses          9        9           
Flag Coverage Δ
unittests 83.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ui/menu_nbgl.c Show resolved Hide resolved
src/ui/menu_nbgl.c Show resolved Hide resolved
@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl-settingsv2 branch 3 times, most recently from fac080d to 8c2fbb5 Compare March 27, 2024 15:16
@xchapron-ledger xchapron-ledger changed the title src/ui/menu_nbgl.c: Use nbgl_useCaseSettingsV2() src/ui: Update NBGL UI based on new API Mar 27, 2024
@xchapron-ledger xchapron-ledger force-pushed the xch/nbgl-settingsv2 branch 2 times, most recently from d7480c6 to ca59959 Compare April 2, 2024 14:05
@xchapron-ledger xchapron-ledger marked this pull request as ready for review April 4, 2024 09:22
Xavier Chapron and others added 2 commits April 11, 2024 17:57
Removed main menu navigation test that should belong in the SDK
@xchapron-ledger xchapron-ledger changed the title src/ui: Update NBGL UI based on new API src:ui / tests: Update UI and tests based on new API Apr 11, 2024
lpascal-ledger
lpascal-ledger previously approved these changes Apr 12, 2024
lpascal-ledger
lpascal-ledger previously approved these changes Apr 12, 2024
@xchapron-ledger xchapron-ledger merged commit f78ac67 into master Apr 12, 2024
46 of 48 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/nbgl-settingsv2 branch April 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants