Merge pull request #19 from LedgerHQ/fix/apa/incorrect_signature

Fix the plugin making the Ethereum app generate incorrect signatures
LedgerHQ · Feb 12, 2024 · 838dd9e · 838dd9e
2 parents 7373e0c + 510ab71
commit 838dd9e
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/src/handle_provide_parameter.c b/src/handle_provide_parameter.c
@@ -65,27 +65,20 @@ int find_lr_known_strategy(const char address[ADDRESS_STR_LEN]) {
 void handle_lr_deposit_into_strategy(ethPluginProvideParameter_t *msg, context_t *context) {
     uint8_t buffer[ADDRESS_LENGTH];
     char address_buffer[ADDRESS_STR_LEN];
+    cx_sha3_t sha3;
 
     switch (context->next_param) {
         case LR_DEPOSIT_INTO_STRATEGY_STRATEGY:
             copy_address(buffer, msg->parameter, sizeof(buffer));
-            getEthDisplayableAddress(buffer,
-                                     address_buffer,
-                                     sizeof(address_buffer),
-                                     msg->pluginSharedRW->sha3,
-                                     0);
+            getEthDisplayableAddress(buffer, address_buffer, sizeof(address_buffer), &sha3, 0);
             context->param_data.lr_deposit.strategy_to_display =
                 find_lr_known_strategy(address_buffer);
 
             context->next_param = LR_DEPOSIT_INTO_STRATEGY_TOKEN;
             break;
         case LR_DEPOSIT_INTO_STRATEGY_TOKEN:
             copy_address(buffer, msg->parameter, sizeof(buffer));
-            getEthDisplayableAddress(buffer,
-                                     address_buffer,
-                                     sizeof(address_buffer),
-                                     msg->pluginSharedRW->sha3,
-                                     0);
+            getEthDisplayableAddress(buffer, address_buffer, sizeof(address_buffer), &sha3, 0);
             context->param_data.lr_deposit.erc20_to_display = find_lr_known_erc20(address_buffer);
 
             context->next_param = LR_DEPOSIT_INTO_STRATEGY_AMOUNT;
@@ -105,6 +98,8 @@ void handle_lr_deposit_into_strategy(ethPluginProvideParameter_t *msg, context_t
 }
 
 void handle_lr_queue_withdrawal(ethPluginProvideParameter_t *msg, context_t *context) {
+    cx_sha3_t sha3;
+
     // queueWithdrawal(uint256[],address[],uint256[],address,bool
     // example for queue withdrawal with 2 strategies indexes, contracts and shares
     // [0] selector
@@ -169,7 +164,7 @@ void handle_lr_queue_withdrawal(ethPluginProvideParameter_t *msg, context_t *con
             getEthDisplayableAddress(buffer,
                                      context->param_data.lr_queue_withdrawal.withdrawer,
                                      sizeof(context->param_data.lr_queue_withdrawal.withdrawer),
-                                     msg->pluginSharedRW->sha3,
+                                     &sha3,
                                      0);
             context->next_param = LR_QUEUE_WITHDRAWAL_UNDELEGATEIFPOSSIBLE;
             break;