-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the app, fix bugs and add tests. #43
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
==========================================
Coverage ? 77.72%
==========================================
Files ? 12
Lines ? 2352
Branches ? 0
==========================================
Hits ? 1828
Misses ? 524
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
## Updated - Added a `Sequence Number` setting: `Displayed` or `NOT Displayed`, default to `NOT Displayed`. - Optimized the display of amount. (ex. `10000000 XLM` -> `10,000,000 XLM`) - Optimized the display of offer price. - Optimize the display of `Memo Text` and `Manage Data Value`, if they are printable ASCII characters, they will be printed directly, otherwise display the base64 encoded summary. - In some common operations, the prompt for the operation type was removed. - Other UX improvements. - Other bugfixes. - Refactored this app based on [app-boilerplate](https://github.com/ledgerhq/app-boilerplate). - Refactored unit tests and added full e2e tests. - Added APDU documentation. ## Breaking changes - Removed keypair validation in `GET_PUBLIC_KEY` command. If necessary, we recommend that you ask the user to confirm the address on the device. - Removed support for the `KEEP_ALIVE` command at the app layer.
@lpascal-ledger It looks like the CI run failed after the merge, let me check. |
@lpascal-ledger Looks like the |
@overcat I'm on it, don't worry. Bitcoin application cutoff some legacy last week so it's expected. Nice CI though. |
@lpascal-ledger I made a duplicate PR #45 since I didn't notice that you made a PR |
Note
Changelog
Updated
Sequence Number
setting:Displayed
orNOT Displayed
, default toNOT Displayed
. (resolves Sequence Number setting #40)10000000 XLM
->10,000,000 XLM
) (resolves Use commas in amount formatting #39)Memo Text
andManage Data Value
, if they are printable ASCII characters, they will be printed directly, otherwise display the base64 encoded summary.Breaking changes
GET_PUBLIC_KEY
command. If necessary, we recommend that you ask the user to confirm the address on the device.KEEP_ALIVE
command at the app layer.