Skip to content

Add review pending support #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

Add review pending support #65

merged 4 commits into from
Jan 26, 2023

Conversation

@Ericson2314
Copy link
Contributor

No description provided.

Ericson2314 and others added 3 commits January 13, 2023 17:37
@Ericson2314
WIP add review pending support
9aa5d2b 
We just added the C files from the SDK, but not yet the C UX
functionality it depends upon.
@dbzguy56
Fix build
b3cb921 
Got a minimized `os.c` from the c sdk which provides `os_parse_bertlv`
needed for `checks.c`.

`check_audited_app` no longer tries to render the menu itself, but
instead calls `sample_pending`.
@dbzguy56
Merge remote-tracking branch 'upstream/master' into flag-for-pending
fd43fd6
@Ericson2314 Ericson2314 mentioned this pull request Jan 18, 2023
Merged
dbzguy56 added a commit to obsidiansystems/ledger-app-rust-example that referenced this pull request Jan 19, 2023
@dbzguy56
Temporarily point to our sdk
f72366c 
LedgerHQ/ledger-device-rust-sdk#65
@Ericson2314 Ericson2314 marked this pull request as ready for review January 25, 2023 15:14
@yhql yhql merged commit 7785e32 into LedgerHQ:master Jan 26, 2023
@Ericson2314 Ericson2314 deleted the flag-for-pending branch January 26, 2023 14:58
superstar0402 added a commit to superstar0402/boilerplate that referenced this pull request Aug 19, 2024
@superstar0402
Temporarily point to our sdk
e57ebf5 
LedgerHQ/ledger-device-rust-sdk#65
ghallak pushed a commit to aeternity/ledger-app that referenced this pull request Mar 26, 2025
@dbzguy56 @ghallak
Temporarily point to our sdk
e90997a 
LedgerHQ/ledger-device-rust-sdk#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @yhql @dbzguy56