Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

[LL-8105] add fund flow logic #4426

Merged
1 commit merged into from
Jan 5, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2021

🦒 Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LL-8105

Built on top of #4361

🔗 LedgerHQ/ledger-live-common#1525
🔗 https://github.com/LedgerHQ/poc-platform/pull/1

💻 Description / Demo (image or video)

Handle fund flow in LLD

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

How to test

Use the linked poc platform PR, start it locally (yarn dev) and add the following local manifest to your LLD

manifest.json:

{
  "id": "test-exchange",
  "name": "Test exchange",
  "url": "http://localhost:3000",
  "homepageUrl": "https://developers.ledger.com/",
  "icon": "",
  "platform": "all",
  "apiVersion": "0.0.1",
  "manifestVersion": "1",
  "branch": "debug",
  "categories": ["tools"],
  "currencies": "*",
  "content": {
    "shortDescription": {
      "en": "Test fund / swap"
    },
    "description": {
      "en": "Test fund / swap"
    }
  },
  "permissions": [
    {
      "method": "*"
    }
  ],
  "domains": ["https://*"]
}

@ghost ghost marked this pull request as ready for review January 5, 2022 13:28
@ghost ghost merged commit e88de80 into LL-7803_sell-flow-poc Jan 5, 2022
@valpinkman valpinkman deleted the LL-8105_add-fund-flow-logic branch January 5, 2022 17:17
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants