Skip to content

Commit

Permalink
Apply switch toggle directly rather than just modifying the input
Browse files Browse the repository at this point in the history
  • Loading branch information
ofreyssinet-ledger committed Sep 28, 2022
1 parent cf73c10 commit 33af91a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ const FeatureFlagEdit: React.FC<{ flagName: FeatureId; flagValue: Feature }> = p

const handleSwitchChange = useCallback(
enabled => {
handleInputChange(JSON.stringify({ ...parsedInput, enabled }));
featureFlagsProvider.overrideFeature(flagName, { ...flagValue, enabled });
},
[parsedInput, handleInputChange],
[featureFlagsProvider, flagName, flagValue],
);

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,11 @@ const FeatureFlagEdit: React.FC<{

const handleSwitchChange = useCallback(
enabled => {
handleInputChange(JSON.stringify({ ...parsedInput, enabled }));
featureFlagsProvider.overrideFeature(flagName, { ...flagValue, enabled });
},
[parsedInput, handleInputChange],
[featureFlagsProvider, flagName, flagValue],
);

return (
<Flex>
{error ? (
Expand Down

0 comments on commit 33af91a

Please sign in to comment.