Skip to content

Commit

Permalink
refactor(listAppsV1): pass managerApiRepository argument
Browse files Browse the repository at this point in the history
  • Loading branch information
ofreyssinet-ledger committed Feb 5, 2024
1 parent 511d838 commit 4f1371f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion libs/ledger-live-common/src/apps/listApps/v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { getEnv } from "@ledgerhq/live-env";
import { calculateDependencies, polyfillApp, polyfillApplication } from "../polyfill";
import getDeviceName from "../../hw/getDeviceName";
import { getLatestFirmwareForDeviceUseCase } from "../../device/use-cases/getLatestFirmwareForDeviceUseCase";
import { ManagerApiRepository } from "../../device-core/managerApi/repositories/ManagerApiRepository";

const appsThatKeepChangingHashes = ["Fido U2F", "Security Key"];

Expand All @@ -28,6 +29,7 @@ const emptyHashData = "000000000000000000000000000000000000000000000000000000000
export const listApps = (
transport: Transport,
deviceInfo: DeviceInfo,
managerApiRepository: ManagerApiRepository,
): Observable<ListAppsEvent> => {
const tracer = new LocalTracer("list-apps", { transport: transport.getTraceContext() });
tracer.trace("Using legacy version", { deviceInfo });
Expand Down Expand Up @@ -90,7 +92,10 @@ export const listApps = (
}),
);

const latestFirmwareForDeviceP = getLatestFirmwareForDeviceUseCase(deviceInfo);
const latestFirmwareForDeviceP = getLatestFirmwareForDeviceUseCase(
deviceInfo,
managerApiRepository,
);

const firmwareP = Promise.all([firmwareDataP, latestFirmwareForDeviceP]).then(
([firmwareData, updateAvailable]) => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function listAppsUseCase(
managerApiRepository: ManagerApiRepository = HttpManagerApiRepositoryFactory.getInstance(),
): Observable<ListAppsEvent> {
return listAppsV2Enabled
? listAppsV1(transport, deviceInfo)
? listAppsV1(transport, deviceInfo, managerApiRepository)
: listAppsV2({
transport,
deviceInfo,
Expand Down

0 comments on commit 4f1371f

Please sign in to comment.