Skip to content

Commit

Permalink
chore: Turn off Allure Reports Export on Server CI jobs (#6106)
Browse files Browse the repository at this point in the history
Includes 2 readme type fixes to test the workflows
  • Loading branch information
aboissiere-ledger authored Feb 7, 2024
1 parent 1975deb commit e6caa3b
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 81 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/test-desktop-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -350,26 +350,3 @@ jobs:
name: summary.json
path: ${{ github.workspace }}/summary.json

allure-report:
name: "Allure Reports Export on Server"
needs: [e2e-tests-linux]
runs-on: [ledger-live-medium-linux]
if: ${{ !cancelled() && github.ref_name == 'develop' }}
steps:
- name: checkout
uses: actions/checkout@v4
with:
ref: ${{ github.ref_name }}
- name: Download Allure Report - Linux
uses: actions/download-artifact@v3
with:
name: allure-results-linux
path: allure-results-linux
- name: Send Results and Generate Allure Report - Linux
uses: ./tools/actions/composites/upload-allure-report
if: ${{ !cancelled() }}
with:
platform: linux
login: ${{ secrets.ALLURE_LOGIN }}
password: ${{ secrets.ALLURE_PASSWORD }}
path: allure-results-linux
23 changes: 0 additions & 23 deletions .github/workflows/test-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -413,26 +413,3 @@ jobs:
name: summary.json
path: ${{ github.workspace }}/summary.json

allure-report:
name: "Allure Reports Export on Server"
needs: e2e-tests-linux
runs-on: [ledger-live-medium-linux]
if: ${{ !cancelled() && github.ref_name == 'develop' }}
steps:
- name: checkout
uses: actions/checkout@v4
with:
ref: ${{ (github.event_name == 'workflow_dispatch' && (inputs.ref || github.ref_name)) || github.sha }}
- name: Download Allure Report - Linux
uses: actions/download-artifact@v3
with:
name: allure-results-linux
path: allure-results-linux
- name: Send Results and Generate Allure Report - Linux
uses: ./tools/actions/composites/upload-allure-report
if: ${{ !cancelled() }}
with:
platform: linux
login: ${{ secrets.ALLURE_LOGIN }}
password: ${{ secrets.ALLURE_PASSWORD }}
path: allure-results-linux
33 changes: 0 additions & 33 deletions .github/workflows/test-mobile-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,22 +157,6 @@ jobs:
name: "allure-ios-reports"
path: apps/ledger-live-mobile/allure-results

allure-report-ios:
name: "Allure Reports Export on Server"
runs-on: [ledger-live-medium-linux]
if: ${{ !cancelled() && github.ref_name == 'develop' }}
needs: [detox-tests-ios]
steps:
- uses: actions/checkout@v4
with:
ref: ${{ (github.event_name == 'workflow_dispatch' && (inputs.ref || github.ref_name)) || github.sha }}
- uses: ./tools/actions/composites/upload-allure-report
with:
platform: ios
login: ${{ secrets.ALLURE_LOGIN }}
password: ${{ secrets.ALLURE_PASSWORD }}
path: allure-ios-reports

detox-tests-android:
name: "Ledger Live Mobile - Android Detox Tests"
runs-on: [ledger-live-linux-8CPU-32RAM]
Expand Down Expand Up @@ -297,23 +281,6 @@ jobs:
name: "allure-android-reports"
path: apps/ledger-live-mobile/allure-results

allure-report-android:
name: "Allure Reports Export on Server"
runs-on: [ledger-live-medium-linux]
if: ${{ !cancelled() && github.ref_name == 'develop' }}
needs: [detox-tests-android]
steps:
- name: checkout
uses: actions/checkout@v4
with:
ref: ${{ (github.event_name == 'workflow_dispatch' && (inputs.ref || github.ref_name)) || github.sha }}
- uses: ./tools/actions/composites/upload-allure-report
with:
platform: android
login: ${{ secrets.ALLURE_LOGIN }}
password: ${{ secrets.ALLURE_PASSWORD }}
path: allure-android-reports

report:
needs: [detox-tests-android, detox-tests-ios]
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion apps/ledger-live-desktop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ If you are using [Visual Studio Code](https://code.visualstudio.com/) IDE, we pr
}
```

To get the PATH, run in your terminal
To get the PATH, run in your terminal:

```bash
echo $PATH
Expand Down
2 changes: 1 addition & 1 deletion apps/ledger-live-mobile/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ You need to have metro running with `pnpm dev:llm` then `pnpm mobile android` in

### `pnpm mobile android:clean`

Delete the application data for Ledger Live Mobile, equivalent to doing it manually through settings
Delete the application data for Ledger Live Mobile, equivalent to doing it manually through settings.

### `pnpm build:llm:ios`

Expand Down

0 comments on commit e6caa3b

Please sign in to comment.