Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for RTL in iOS and Android configuration files. #1188

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Sep 6, 2022

📝 Description

Config to allow RTL support in apps conf files. Tested on both Android and iOS.

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): LIVE-3031

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

N/A

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022

⚠️ No Changeset found

Latest commit: b9f32ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 1:01PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 6, 2022 at 1:01PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 1:01PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 1:01PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

@mlegall-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1188 (0484004) into feat/LIVE-2987/RTL-arabic-support (6edf507) will increase coverage by 47.00%.
The diff coverage is n/a.

❗ Current head 0484004 differs from pull request most recent head b9f32ca. Consider uploading reports for the commit b9f32ca to get more accurate results

@@                          Coverage Diff                           @@
##           feat/LIVE-2987/RTL-arabic-support    #1188       +/-   ##
======================================================================
+ Coverage                                   0   47.00%   +47.00%     
======================================================================
  Files                                      0      627      +627     
  Lines                                      0    28200    +28200     
  Branches                                   0     7397     +7397     
======================================================================
+ Hits                                       0    13254    +13254     
- Misses                                     0    14898    +14898     
- Partials                                   0       48       +48     
Flag Coverage Δ
test 47.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ledgerjs/packages/hw-app-btc/src/newops/policy.ts 91.66% <0.00%> (ø)
...ve-common/src/families/polkadot/api/bisontrails.ts 16.66% <0.00%> (ø)
...src/families/crypto_org/js-estimateMaxSpendable.ts 55.55% <0.00%> (ø)
...edger-live-common/src/families/celo/transaction.ts 57.14% <0.00%> (ø)
...dger-live-common/src/families/solana/api/logged.ts 7.69% <0.00%> (ø)
...on/src/families/osmosis/js-getTransactionStatus.ts 100.00% <0.00%> (ø)
...js/packages/hw-app-btc/src/serializeTransaction.ts 100.00% <0.00%> (ø)
.../src/exchange/swap/hooks/usePickDefaultCurrency.ts 100.00% <0.00%> (ø)
...-common/src/families/osmosis/js-synchronization.ts 20.83% <0.00%> (ø)
...ve-common/src/families/stellar/js-signOperation.ts 22.91% <0.00%> (ø)
... and 617 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mle-gall mle-gall merged commit 62d8cb8 into feat/LIVE-2987/RTL-arabic-support Sep 6, 2022
@mle-gall mle-gall deleted the feat/LIVE-3031/RTLSetup branch September 6, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants